You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@chargome I'm not entirely sure what you mean, but I'm not a JavaScript developer, just a C++ developer, and these changes are specifically to support C++ exceptions compiled to wasm and caught by JavaScript (it's a bit complicated 🙈).
If you're asking whether wasm can still throw exceptions in the browser, then yes it can: https://developer.mozilla.org/en-US/docs/WebAssembly/Reference/JavaScript_interface/Exception
I don't know how it looks in node, it's possible that you need to update one of the new functions when the environment is node: isWebAssemblyException / extractType.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for wasm WebAssembly.Exception (uncaught exception in emscripten).
References